3-group-ios/GBA002
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixes crash when customizing app icon shortcuts

Browse Source
This commit is contained in:
Riley Testut 2021-01-04 14:01:05 -06:00
parent 9f2f1bad77
commit ced5d6099e
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Delta/Settings/App Icon Shortcuts/AppIconShortcutsViewController.swift
View File

@ -197,11 +197,9 @@ private extension AppIconShortcutsViewController
func addShortcut(for game: Game) func addShortcut(for game: Game)
{ {
guard self.shortcutsDataSource.items.count < 4 else { return } guard self.shortcutsDataSource.items.count < 4 else { return }
guard !self.shortcutsDataSource.items.contains(game) else { return } guard !self.shortcutsDataSource.items.contains(game) else { return }
// No need to adjust destinationIndexPath, since it forwards change directly to table view. let destinationIndexPath = IndexPath(row: self.shortcutsDataSource.items.count, section: 0)
let destinationIndexPath = IndexPath(row: self.shortcutsDataSource.items.count, section: 1)
let insertion = RSTCellContentChange(type: .insert, currentIndexPath: nil, destinationIndexPath: destinationIndexPath) let insertion = RSTCellContentChange(type: .insert, currentIndexPath: nil, destinationIndexPath: destinationIndexPath)
insertion.rowAnimation = .fade insertion.rowAnimation = .fade
@ -295,11 +293,13 @@ extension AppIconShortcutsViewController
{ {
case .none: break case .none: break
case .delete: case .delete:
let deletion = RSTCellContentChange(type: .delete, currentIndexPath: indexPath, destinationIndexPath: nil) let adjustedIndexPath = IndexPath(row: indexPath.row, section: 0)
let deletion = RSTCellContentChange(type: .delete, currentIndexPath: adjustedIndexPath, destinationIndexPath: nil)
deletion.rowAnimation = .fade deletion.rowAnimation = .fade
var shortcuts = self.shortcutsDataSource.items var shortcuts = self.shortcutsDataSource.items
shortcuts.remove(at: indexPath.row) // No need to adjust indexPath, since it forwards change directly to table view. shortcuts.remove(at: adjustedIndexPath.row)
self.shortcutsDataSource.setItems(shortcuts, with: [deletion]) self.shortcutsDataSource.setItems(shortcuts, with: [deletion])
case .insert: case .insert: