3-group-ios/GBA002
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed incorrect game rendering when rotating while paused

Browse Source 
When rotating EmulationViewController with PauseViewController presented, the GameView would have an incorrectly sized rendered image
This commit is contained in:
Riley Testut 2015-12-26 02:45:57 -06:00
parent 8f572fd1c8
commit 76a9c85253
2 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Cores/DeltaCore

@ -1 +1 @@
Subproject commit cc58e545e2e72494f7aaa9f409e8404f4d549f56 Subproject commit 3cd685cb2b1a5756501c240416d70ab2d33df885

24
Delta/Emulation/EmulationViewController.swift
View File

@ -39,6 +39,8 @@ class EmulationViewController: UIViewController
return NSStringFromClass(presentationController.dynamicType).containsString("PreviewPresentation") return NSStringFromClass(presentationController.dynamicType).containsString("PreviewPresentation")
} }
private var _isPauseViewControllerPresented = false
//MARK: - Initializers - //MARK: - Initializers -
/** Initializers **/ /** Initializers **/
@ -110,15 +112,23 @@ class EmulationViewController: UIViewController
} }
/// <UIContentContainer> /// <UIContentContainer>
override func willTransitionToTraitCollection(newCollection: UITraitCollection, withTransitionCoordinator coordinator: UIViewControllerTransitionCoordinator) override func viewWillTransitionToSize(size: CGSize, withTransitionCoordinator coordinator: UIViewControllerTransitionCoordinator)
{ {
super.willTransitionToTraitCollection(newCollection, withTransitionCoordinator: coordinator) super.viewWillTransitionToSize(size, withTransitionCoordinator: coordinator)
self.controllerView.beginAnimatingUpdateControllerSkin() self.controllerView.beginAnimatingUpdateControllerSkin()
coordinator.animateAlongsideTransition(nil) { (context) in coordinator.animateAlongsideTransition({ _ in
self.controllerView.finishAnimatingUpdateControllerSkin()
} if self._isPauseViewControllerPresented
{
// We need to manually "refresh" the game screen, otherwise the system tries to cache the rendered image, but skews it incorrectly when rotating b/c of UIVisualEffectView
self.gameView.inputImage = self.gameView.outputImage
}
}, completion: { _ in
self.controllerView.finishAnimatingUpdateControllerSkin()
})
} }
// MARK: - Navigation - // MARK: - Navigation -
@ -134,11 +144,15 @@ class EmulationViewController: UIViewController
{ {
pauseViewController.pauseText = self.game.name pauseViewController.pauseText = self.game.name
} }
self._isPauseViewControllerPresented = true
} }
} }
@IBAction func unwindFromPauseViewController(segue: UIStoryboardSegue) @IBAction func unwindFromPauseViewController(segue: UIStoryboardSegue)
{ {
self._isPauseViewControllerPresented = false
self.emulatorCore.resumeEmulation() self.emulatorCore.resumeEmulation()
} }