3-group-ios/GBA002
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removes unnecessary image network request when sizing GameCollectionViewController cells

Browse Source
This commit is contained in:
Riley Testut 2016-11-22 19:50:13 -08:00
parent 5f2991ea47
commit 103d5cecf1
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Delta/Game Selection/GameCollectionViewController.swift
View File

@ -174,7 +174,7 @@ private extension GameCollectionViewController
} }
//MARK: - Configure Cells //MARK: - Configure Cells
func configure(_ cell: GridCollectionViewCell, for indexPath: IndexPath) func configure(_ cell: GridCollectionViewCell, for indexPath: IndexPath, ignoreImageOperations: Bool = false)
{ {
let game = self.dataSource.fetchedResultsController.object(at: indexPath) let game = self.dataSource.fetchedResultsController.object(at: indexPath)
@ -194,7 +194,7 @@ private extension GameCollectionViewController
cell.maximumImageSize = CGSize(width: 90, height: 90) cell.maximumImageSize = CGSize(width: 90, height: 90)
cell.textLabel.text = game.name cell.textLabel.text = game.name
if let artworkURL = game.artworkURL if let artworkURL = game.artworkURL, !ignoreImageOperations
{ {
cell.imageView.sd_setImage(with: artworkURL, placeholderImage: #imageLiteral(resourceName: "BoxArt"), options: .continueInBackground) { (image, error, type, url) in cell.imageView.sd_setImage(with: artworkURL, placeholderImage: #imageLiteral(resourceName: "BoxArt"), options: .continueInBackground) { (image, error, type, url) in
@ -429,7 +429,7 @@ extension GameCollectionViewController: UICollectionViewDelegateFlowLayout
widthConstraint.isActive = true widthConstraint.isActive = true
defer { widthConstraint.isActive = false } defer { widthConstraint.isActive = false }
self.configure(self.prototypeCell, for: indexPath) self.configure(self.prototypeCell, for: indexPath, ignoreImageOperations: true)
let size = self.prototypeCell.contentView.systemLayoutSizeFitting(UILayoutFittingCompressedSize) let size = self.prototypeCell.contentView.systemLayoutSizeFitting(UILayoutFittingCompressedSize)
return size return size