3-group-ios/GBA001
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixes crash when restoring remote record without local version

Browse Source
This commit is contained in:
Riley Testut 2023-08-10 19:19:30 -05:00
parent fcdd3c7840
commit be047b28a6
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Delta/Settings/Syncing/RecordVersionsViewController.swift
View File

@ -136,7 +136,7 @@ private extension RecordVersionsViewController
let localVersionsDataSource = RSTDynamicTableViewDataSource<Version>()
localVersionsDataSource.numberOfSectionsHandler = { 1 }
localVersionsDataSource.numberOfItemsHandler = { [weak self] _ in self?.record.localModificationDate != nil ? 1 : 0 }
localVersionsDataSource.numberOfItemsHandler = { [weak self] _ in self?.record.localModificationDate != nil ? 1 : 0 } // fetchVersions() assumes this logic, so update there too.
localVersionsDataSource.cellConfigurationHandler = { [weak self] (cell, _, indexPath) in
guard let `self` = self else { return }
@ -200,6 +200,19 @@ private extension RecordVersionsViewController
self.versions = versions
DispatchQueue.main.async {
let previousLocalVersionExists = self.tableView.numberOfRows(inSection: Section.local.rawValue) > 0
let localVersionExists = self.record.localModificationDate != nil
let localVersionIndexPath = IndexPath(row: 0, section: Section.local.rawValue)
if !previousLocalVersionExists && localVersionExists
{
self.tableView.insertRows(at: [localVersionIndexPath], with: .fade)
}
else if previousLocalVersionExists && !localVersionExists
{
self.tableView.deleteRows(at: [localVersionIndexPath], with: .fade)
}
let count = self.tableView.numberOfRows(inSection: Section.remote.rawValue)
let deletions = (0 ..< count).map { (row) -> RSTCellContentChange in