From a592d6e2ad24c6b10017ad24aa89e50b785d90a9 Mon Sep 17 00:00:00 2001 From: Riley Testut Date: Tue, 26 Sep 2017 13:09:15 -0700 Subject: [PATCH] Fixes incorrect GamesViewController content insets --- Delta/Base.lproj/Main.storyboard | 13 +++++----- .../Game Selection/GamesViewController.swift | 26 ++++++++++++++----- 2 files changed, 25 insertions(+), 14 deletions(-) diff --git a/Delta/Base.lproj/Main.storyboard b/Delta/Base.lproj/Main.storyboard index c740d7e..ab299d3 100644 --- a/Delta/Base.lproj/Main.storyboard +++ b/Delta/Base.lproj/Main.storyboard @@ -1,11 +1,11 @@ - + - + @@ -31,8 +31,8 @@ - + @@ -57,7 +57,7 @@ - + @@ -183,12 +183,11 @@ - + - @@ -213,7 +212,7 @@ - + diff --git a/Delta/Game Selection/GamesViewController.swift b/Delta/Game Selection/GamesViewController.swift index a4fcb3e..7067982 100644 --- a/Delta/Game Selection/GamesViewController.swift +++ b/Delta/Game Selection/GamesViewController.swift @@ -109,11 +109,15 @@ extension GamesViewController { super.viewDidLayoutSubviews() - if let viewControllers = self.pageViewController.viewControllers as? [GameCollectionViewController] + if #available(iOS 11.0, *) {} + else { - for viewController in viewControllers + if let viewControllers = self.pageViewController.viewControllers as? [GameCollectionViewController] { - viewController.collectionView?.contentInset.top = self.topLayoutGuide.length + for viewController in viewControllers + { + viewController.collectionView?.contentInset.top = self.topLayoutGuide.length + } } } } @@ -190,8 +194,12 @@ private extension GamesViewController viewController.theme = self.theme viewController.activeEmulatorCore = self.activeEmulatorCore - // Need to set content inset here AND willTransitionTo callback to ensure its correct for all edge cases - viewController.collectionView?.contentInset.top = self.topLayoutGuide.length + if #available(iOS 11.0, *) {} + else + { + // Need to set content inset here AND willTransitionTo callback to ensure its correct for all edge cases + viewController.collectionView?.contentInset.top = self.topLayoutGuide.length + } return viewController } @@ -366,9 +374,13 @@ extension GamesViewController: UIPageViewControllerDataSource, UIPageViewControl { guard let viewControllers = pendingViewControllers as? [GameCollectionViewController] else { return } - for viewController in viewControllers + if #available(iOS 11.0, *) {} + else { - viewController.collectionView?.contentInset.top = self.topLayoutGuide.length + for viewController in viewControllers + { + viewController.collectionView?.contentInset.top = self.topLayoutGuide.length + } } }